Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BIP-174 test vectors #11

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add BIP-174 test vectors #11

merged 1 commit into from
Dec 12, 2023

Conversation

tcharding
Copy link
Owner

@tcharding tcharding commented Dec 11, 2023

Add all the test vectors:

  • The parsing stuff is re-written from scratch
  • The complex stuff in bip-174.rs is copied directly from rust-bitcoin/bitcoin/tests/psbt.rs where it was written by myself, Dan, and Armin.
  • The signer checks stuff is written new, it never existed in rust-bitcoin

See co-developed-by tag for email addresses of the other two devs.

@tcharding tcharding force-pushed the bip-174-test-vectors branch from 716a6b7 to e0b0471 Compare December 12, 2023 03:28
@tcharding
Copy link
Owner Author

Hey @DanGould I copied the stuff from rust-bitcoin that you and I wrote last year. Some of the commits from then include a fella named Armin but I don't remember his github username. I kept his name in a co-developed-by tag in the patch out of courtesy.

Add all the test vectors, the parsing stuff is re-written, but the
complex stuff in `bip-174.rs` is copied directly from
`rust-bitcoin/bitcoin/tests/psbt.rs` where it was written by myself,
Dan, and Armin.

Co-developed-by: DanGould <[email protected]>
Co-developed-by: Armin Sabouri <[email protected]>
@tcharding tcharding force-pushed the bip-174-test-vectors branch from e0b0471 to 5245faf Compare December 12, 2023 04:48
@tcharding
Copy link
Owner Author

Force push adds the signer checks, with a couple of todo's left in there. The code is pretty racy.

@tcharding tcharding marked this pull request as ready for review December 12, 2023 04:49
@tcharding tcharding changed the title WIP: Add bip-174 test vectors Add BIP-174 test vectors Dec 12, 2023
@tcharding tcharding merged commit b43424a into master Dec 12, 2023
4 checks passed
@DanGould
Copy link
Collaborator

DanGould commented Dec 13, 2023

I'm sure @0xBEEFCAF3 would understand

@0xBEEFCAF3
Copy link

All good here!
Thanks @tcharding

@tcharding tcharding deleted the bip-174-test-vectors branch December 13, 2023 01:51
@tcharding
Copy link
Owner Author

Legend, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants